fix: bulk data hash generation is broken#12
Merged
AKrantzPS merged 1 commit intoJun 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and test coverage of the bulk data collection logic in the
Collectorclass, specifically focusing on how bulk hashes are computed for local columns. The main changes include making the hash calculation ignore theidattribute, handling missing attributes and HTTP errors gracefully, and adding comprehensive tests to cover these scenarios.FIX: Do not add
AoLocalColumn.idto hash generation any more. The Hash generation was broken since the start and should work now.Bulk hash calculation improvements:
_collect_bulk_datanow dynamically determines which attributes to include and explicitly skips theidattribute in the hash, ensuring that only relevant data changes affect the hash.Error handling enhancements:
idorvalues) and skips hash calculation for those cases, logging a warning instead of failing.Test coverage improvements:
test_collect.pyto verify:idfield.idfield changes.Testing utilities:
Collectorclass. [1] [2]